RFR [15] : 8249029: clean up FileInstaller $test.src $cwd in vmTestbase_vm_defmeth tests

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jul 14 18:18:12 UTC 2020


Thanks David,

pushed to jdk15.

-- Igor

> On Jul 13, 2020, at 7:42 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Looks good!
> 
> Thanks,
> David
> 
> On 9/07/2020 5:43 am, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8249029/webrev.00
>>> 750 lines changed: 0 ins; 376 del; 374 mod;
>> Hi all,
>> could you please review the patch which removes `FileInstaller . .` jtreg action from :vmTestbase_vm_defmeth tests?
>> from the main issue(8204985):
>>> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to mimic old test harness behavior and copy all files from a test source directory to a current work directory. some tests depend on this step, so we need 1st identify such tests and then either rewrite them not to have this dependency or leave FileInstaller only in these tests.
>> effectively, the patch is just `ag -l  '@run driver jdk.test.lib.FileInstaller . .' vmTestbase/vm/runtime/defmeth  | xargs -I{} gsed -i '/@run driver jdk.test.lib.FileInstaller \. \./d' {}`
>> testing: :vmTestbase_vm_defmeth on linux-x64
>> webrev: http://cr.openjdk.java.net/~iignatyev//8249029/webrev.00
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8249029
>> Thanks,
>> -- Igor



More information about the hotspot-runtime-dev mailing list