RFR (S) 8237591: Mac: include OS X version in hs_err_pid crash log file

[David Holmes]

Hi Gerard,

On 18/07/2020 5:19 am, gerard ziemski wrote:
> Hi all,
> 
> Please review this small fix that adds the OS version and the OS build 
> number to the hs_err_pidXXX.log output in the “Summary” section for Mac 
> platform (it’s easier to use for developers than the Darwin kernel 
> version that we display right now).
> 
> This is how things used to look:
> 
> 
> --------------- S U M M A R Y ------------
> 
> Command Line: Crasher
> 
> Host: Gerards-MBP-16, MacBookPro16,1 x86_64 2600 MHz, 12 cores, 32G, 
> Darwin 19.5.0
> Time: Thu Jul 16 14:01:46 2020 CDT elapsed time: 1.089465 seconds (0d 0h 
> 0m 1s)
> 
> 
> And this is how the “Summary” section looks like with the proposed change:
> 
> 
> --------------- S U M M A R Y ------------
> 
> Command Line: Crasher
> 
> Host: Gerards-MBP-16, MacBookPro16,1 x86_64 2600 MHz, 12 cores, 32G, 
> Darwin 19.5.0, macOS 10.15.5 (19F101)
> Time: Thu Jul 16 14:02:29 2020 CDT elapsed time: 0.360881 seconds (0d 0h 
> 0m 0s)
> 
> 
> bug link at https://bugs.openjdk.java.net/browse/JDK-8237591
> open webrev at http://cr.openjdk.java.net/~gziemski/8237591_rev1
> testing Mach5 hs_tier1,2,3,4,5 in progress

Just to be clear, the changes prior to:

1555 #ifdef __APPLE__

are just fixing up existing indentation errors - correct?

The actual change seems okay, just one query:

1562     int mib_build[] = { CTL_KERN, KERN_OSVERSION };

I couldn't find KERN_OSVERSION documented for sysctl - is it a "recent" 
addition?

Thanks,
David

> 
> cheers
>