RFR(S): 8246377: [PPC64] Further improvements for assembler stop function

[Doerr, Martin]

Hi Götz,

thanks a lot for reviewing it.

> Only the indentation of the shouldnotreachhere case in the two os files
> looks broken.
I guess you mean the indentation in macroAssembler_ppc.hpp. That was a bit odd. But I've rearranged a few lines in the os files for better readabilty, too. No functional change. Updated webrev in place:
http://cr.openjdk.java.net/~mdoerr/8246377_ppc64_improve_stop/webrev.00/

Best regards,
Martin


> -----Original Message-----
> From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Sent: Mittwoch, 3. Juni 2020 08:15
> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-
> dev at openjdk.java.net; Schmidt, Lutz <lutz.schmidt at sap.com>; Andrew
> Haley (aph at redhat.com) <aph at redhat.com>; Liu, Xin
> <xxinliu at amazon.com>
> Subject: RE: RFR(S): 8246377: [PPC64] Further improvements for assembler
> stop function
> 
> HI Martin,
> 
> This is a good idea to further shrink the code size.
> Looks good.
> 
> Only the indentation of the shouldnotreachhere case in the two os files
> looks broken.
> 
> Best regards,
>   Goetz.
> 
> -----Original Message-----
> From: hotspot-runtime-dev <hotspot-runtime-dev-
> bounces at openjdk.java.net> On Behalf Of Doerr, Martin
> Sent: Mittwoch, 3. Juni 2020 00:34
> To: hotspot-runtime-dev at openjdk.java.net; Schmidt, Lutz
> <lutz.schmidt at sap.com>; Andrew Haley (aph at redhat.com)
> <aph at redhat.com>; Liu, Xin <xxinliu at amazon.com>
> Subject: [CAUTION] RFR(S): 8246377: [PPC64] Further improvements for
> assembler stop function
> 
> Hi,
> 
> I'd like to have the improvements which we discussed for AArch64 also on
> PPC64 (+ a little more).
> 
> Issue with details:
> https://bugs.openjdk.java.net/browse/JDK-8246377
> 
> Webrev:
> http://cr.openjdk.java.net/~mdoerr/8246377_ppc64_improve_stop/webrev
> .00/
> 
> Please review.
> 
> Best regards,
> Martin