RFR (trivial): 8247388: Minimal build broken after JDK-8240245 (undefined reference to `MetaspaceShared::_use_optimized_module_handling')

Ao Qi aoqi at loongson.cn
Thu Jun 11 13:29:53 UTC 2020


On Thu, Jun 11, 2020 at 7:55 PM <coleen.phillimore at oracle.com> wrote:
>
>
> On further viewing, I think adding NOT_CDS_RETURN to
>
> MetaspaceShared::disable_optimized_module_handling();
>
> would be a lot better actually.

Thanks Coleen. New updated webrev:
http://cr.openjdk.java.net/~aoqi/8247388/webrev.01/ Am I understanding
correctly?

Ao Qi

>
> Coleen
>
> On 6/11/20 7:53 AM, coleen.phillimore at oracle.com wrote:
> > This looks good and trivial.
> > thanks,
> > Coleen
> >
> > On 6/11/20 6:15 AM, Ao Qi wrote:
> >> Hi all,
> >>
> >> Could you please review this patch?
> >>
> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8247388
> >> webrev: http://cr.openjdk.java.net/~aoqi/8247388/webrev.00/
> >>
> >> Thanks,
> >> Ao Qi
> >>
> >



More information about the hotspot-runtime-dev mailing list