RFR(s) 8245060: remove copying of s.h.WB$WhiteBoxPermission in cds/appcds tests
Calvin Cheung
calvin.cheung at oracle.com
Fri Jun 12 01:11:11 UTC 2020
Hi Yumin,
On 6/11/20 5:22 PM, Yumin Qi wrote:
>
> My repo showed *test/hotspot/jtreg/runtime/cds/appcds/JarBuilder.java:*
>
> */*
> * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights
> reserved.
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> **
>
> *But your "old" file is year 2019.
> *
>
The copyright of my "old" JarBuilder.java is the same as above.
http://cr.openjdk.java.net/~ccheung/jdk16/8245060/webrev.00/test/hotspot/jtreg/runtime/cds/appcds/JarBuilder.java-.html
Maybe you were reading another file?
I'll correct the copyright year as noted by you and David.
thanks,
Calvin
> **
>
> *Thanks*
>
> *Yumin
> *
>
> *
> *
>
> *
> *
>
> On 6/11/20 5:14 PM, Yumin Qi wrote:
>> Hi, Calvin
>>
>> Why changed 2019 => 2020?
>> It is required for a new repo (jdk16) all the copyright year
>> changed to the starting year for all files?
>>
>>
>> Thanks
>> Yumin
>>
>>
>> On 6/11/20 3:43 PM, Calvin Cheung wrote:
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8245060
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/jdk16/8245060/webrev.00/
>>>
>>> Most changes involve removing the
>>> sun.hotspot.WhiteBox$WhiteBoxPermission from the following:
>>>
>>> @run driver ClassFileInstaller sun.hotspot.WhiteBox
>>> sun.hotspot.WhiteBox$WhiteBoxPermission
>>>
>>> Two additional cleanups:
>>> - remove the unneeded SkippedException related code from the tests
>>> under dynamicArchive/methodHandles;
>>> - remove the JarBuilder.addInnerClasses method since its purpose is
>>> to add the sun.hotspot.WhiteBox$WhiteBoxPermission inner class.
>>>
>>> Passed tier1, 2 tests.
>>>
>>> thanks,
>>>
>>> Calvin
>>>
More information about the hotspot-runtime-dev
mailing list