RFR (S): 8238832: Obsolete PrintVMQWaitTime

[David Holmes]

Hi Dan,

Thanks for the review and for picking up on the pieces I missed.

On 16/06/2020 11:39 pm, Daniel D. Daugherty wrote:
> I did notice one thing while poking around...
> 
> The discussion for:
> 
> "regarding JDK-8236844: Convert PrintVMQWaitTime to unified logging"
> 
> mentioned this:
> 
>> This should be converted to unified logging (or even consider scrapping
>> it completely - which means the VM_Operation timestamp can be deleted).
> 
> But I don't see any changes for removing the VM_Operation timestamp...

I didn't make a note of that at the time and forgot about it. I've now 
removed it.

Ditto for the test issue :( I changed the test to use PrintCodeCache 
instead.

webrev updated in place.

Running tiers 1-3 to re-check everything.

Thanks,
David
-----

> Dan
> 
> 
> On 6/16/20 9:34 AM, Daniel D. Daugherty wrote:
>> On 6/15/20 9:50 PM, David Holmes wrote:
>>> webrev: http://cr.openjdk.java.net/~dholmes/8238832/webrev/
>>
>> src/hotspot/share/runtime/arguments.cpp
>>     No comments.
>>
>> src/hotspot/share/runtime/globals.hpp
>>     No comments.
>>
>> src/hotspot/share/runtime/vmThread.cpp
>>     No comments.
>>
>> Thumbs up.
>>
>> Dan
>>
>>
>>
>>> https://bugs.openjdk.java.net/browse/JDK-8238832
>>>
>>> PrintVMQWaitTime was deprecated in JDK 15 under JDK-8236844 and is 
>>> now obsoleted in JDK 16.
>>>
>>> - The flag table entry is moved to the obsolete flags section.
>>> - the entry in globals.hpp is removed
>>> - the code in vmThread.cpp is removed
>>>
>>> Testing:
>>>  - local build
>>>  - manual check:
>>>
>>> > ../build/linux-x64-debug/images/jdk/bin/java -XX:+PrintVMQWaitTime 
>>> -version
>>> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option 
>>> PrintVMQWaitTime; support was removed in 16.0
>>> java version "16-internal" 2021-03-16
>>> Java(TM) SE Runtime Environment (fastdebug build 
>>> 16-internal+0-2020-06-12-0350435.daholme...)
>>> Java HotSpot(TM) 64-Bit Server VM (fastdebug build 
>>> 16-internal+0-2020-06-12-0350435.daholme..., mixed mode, sharing)
>>>
>>> Thanks,
>>> David
>>> -----
>>
>