RFR(T): 8248049: minor cleanups in gc/whitebox/TestWBGC.java

Harold Seigel harold.seigel at oracle.com
Mon Jun 22 20:32:30 UTC 2020


Looks good and trivial.

Thanks, Harold

On 6/22/2020 4:25 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> During the code review for the following fix:
>
>     JDK-8246477 add whitebox support for deflating idle monitors
>
> David H. made a couple of nit comments on my new test.
> Since I created my test by copying and modifying TestWBGC.java,
> it makes sense to also fix those nits in that test.
>
> Here's the tracking bug:
>
>     JDK-8248049 minor cleanups in gc/whitebox/TestWBGC.java
>     https://bugs.openjdk.java.net/browse/JDK-8248049
>
> And here's the context diffs for a trivial review:
>
> $ hg diff
> diff -r aa1a1a674ec6 test/hotspot/jtreg/gc/whitebox/TestWBGC.java
> --- a/test/hotspot/jtreg/gc/whitebox/TestWBGC.java Mon Jun 22 16:03:40 
> 2020 -0400
> +++ b/test/hotspot/jtreg/gc/whitebox/TestWBGC.java Mon Jun 22 16:06:29 
> 2020 -0400
> @@ -24,9 +24,9 @@
>  package gc.whitebox;
>
>  /*
> - * @test TestWBGC
> + * @test
>   * @bug 8055098
> - * @summary Test verify that WB methods isObjectInOldGen and youngGC 
> works correctly.
> + * @summary Test to verify that WB methods isObjectInOldGen and 
> youngGC work correctly.
>   * @requires vm.gc != "Z" & vm.gc != "Shenandoah"
>   * @library /test/lib
>   * @modules java.base/jdk.internal.misc
>
>
> Thanks, in advance, for any comments, questions or suggestions.
>
> Dan
>


More information about the hotspot-runtime-dev mailing list