RFR (T) 8248271: linux-x86-zero build failure

[coleen.phillimore at oracle.com]

On 6/24/20 7:38 PM, David Holmes wrote:
> Hi Coleen,
>
> On 25/06/2020 9:14 am, coleen.phillimore at oracle.com wrote:
>> See bug for description.  A declaration was missing in os_linux_zero.hpp
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2020/8248271.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8248271
>>
>> mach5 remote-build -b 
>> linux-x64-zero,linux-x64-zero-debug,linux-x86-zero,linux-x86-zero-debug
>>
>> Thanks,
>> Coleen
>>
>> ps. I didn't break this!
>
> Change seems okay but what did break this? I see only three references 
> to workaround_expand_exec_shield_cs_limit:
>
> ./os/linux/os_linux.cpp: workaround_expand_exec_shield_cs_limit();
> ./os_cpu/linux_x86/os_linux_x86.hpp:  static void 
> workaround_expand_exec_shield_cs_limit();
> ./os_cpu/linux_x86/os_linux_x86.cpp:void 
> os::workaround_expand_exec_shield_cs_limit() {
>
> and there are no recent changes to any of those files. ???

I don't think linux_x86_zero is a platform that has ever been built (it 
still fails) even in our build-everything mach5 jobs.

The code for this was added in 2013. 
https://bugs.openjdk.java.net/browse/JDK-8023956

The big change to simplify os/cpu includes might have changed how 
os_linux_x86.hpp was included in zero, but I don't see that in the patch.

The only reason that I noticed is because I have an alias that builds 
all zero builds.

Thanks,
Coleen
>
> Thanks,
> David
>