RFR(T) 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong

Chris Plummer chris.plummer at oracle.com
Thu Jun 25 18:37:23 UTC 2020


Nevermind. I should have looked at your full webrev. I see you already 
covered this.

thanks,

Chris

On 6/25/20 11:28 AM, Chris Plummer wrote:
> Hi Yumin,
>
> It looks like the fix for 
> https://bugs.openjdk.java.net/browse/JDK-8174995 has this same bug. 
> What do you think?
>
> thanks,
>
> Chris
>
> On 6/25/20 10:33 AM, Yumin Qi wrote:
>> Hi, please review the tiny changes for
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8203005
>>
>> webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/
>>
>>
>> Summary: The change was left by 
>> 8074345(https://bugs.openjdk.java.net/browse/JDK-8074345), the types 
>> were wrongly put as T_ILLEGAL for T_OBJECT, and T_ILLEGAL for T_INT. 
>> This has not triggered any failures yet since the types stored in the 
>> type array for nofast version are never used, the used types are 
>> always the original types fortunately(unfortunately either).
>>
>>
>> tests: tier1,tier2,tier3
>>
>>
>> Thanks
>>
>> Yumin
>>
>



More information about the hotspot-runtime-dev mailing list