RFR: 8255128: linux x86 build failure with libJNIPoint.c

Coleen Phillimore coleenp at openjdk.java.net
Tue Nov 3 17:47:59 UTC 2020


On Mon, 2 Nov 2020 18:36:32 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Add 32-bit-safe version of jlong <-> casts to libJNIPoint.c
> 
> This removes the reported warning.
> 
> Note that the _LP64 macro was not being propagated to the benchmark native libraries on Windows. The comment says that this is due to pack200, but since this has been removed [1], it seemed safe to propagate the macro now (backed up by testing).
> 
> CC'ing hotspot-runtime since I know some people there were looking forward to having this fixed.
> 
> Testing: tier1-3
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8232022

Marked as reviewed by coleenp (Reviewer).

test/micro/org/openjdk/bench/jdk/incubator/foreign/points/support/libJNIPoint.c line 32:

> 30: #define PTR_TO_JLONG(value) ((jlong) (value))
> 31: #else
> 32: #define JLONG_TO_PTR(value, type) ((type*) (jint) (value))

Maybe the jlong thisPoint argument comes from a pointer so it's ok.  Not nice, but if you say so, I'll go along.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1017


More information about the hotspot-runtime-dev mailing list