RFR: 8255128: linux x86 build failure with libJNIPoint.c

[Magnus Ihse Bursie]

On Tue, 3 Nov 2020 18:52:52 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> make/autoconf/flags-cflags.m4 line 667:
>> 
>>> 665: 
>>> 666:   if test "x$FLAGS_CPU_BITS" = x64; then
>>> 667:     if test "x$FLAGS_OS" = xlinux || test "x$FLAGS_OS" = xmacosx || test "x$FLAGS_OS" = xwindows; then
>> 
>> At this point, you're almost testing for all supported OSes.  :) I can only think of AIX that does not match this if clause. I think it would be better to just remove the if and always define _LP64=1 on 64-bit platforms. 
>> 
>> @simonis Would that be OK for AIX?
>
> Thanks for the suggestion.
> 
> Note the code that adds _LP64 for the JVM (below):
> 
>     if test "x$FLAGS_OS" != xaix; then
>       # xlc on AIX defines _LP64=1 by default and issues a warning if we redefine it.
>       $1_DEFINES_CPU_JVM="${$1_DEFINES_CPU_JVM} -D_LP64=1"
>     fi
> 
> So, it seems xlc/aix explicitly does _not_ want this macro defined?
> 
> I think we could reuse that if-block to add `-D_LP64=` to both `1_DEFINES_CPU_JDK`, and `1_DEFINES_CPU_JVM` though, and remove the first one that checks for linux/mac/windows.

Yes, that sounds good. I did not notice this (still not used to github reviews, which I think has too little context by default).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1017