RFR: 8255860: Clean up CDS logging related to lambda
Ioi Lam
iklam at openjdk.java.net
Wed Nov 4 18:49:57 UTC 2020
On Wed, 4 Nov 2020 18:41:11 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> A small clean up to make the logging more manageable.
>>
>> [1] Moved some debug printing from `tty->print_cr()` to `-Xlog:cds+lambda=debug`
>> [2] Moved some logs from `-Xlog:cds` to `-Xlog:cds+lambda`
>
> src/hotspot/share/classfile/classListParser.cpp line 464:
>
>> 462:
>> 463: void ClassListParser::resolve_indy(Symbol* class_name_symbol, TRAPS) {
>> 464:
>
> Line deleted by accident?
It's uncommon to have a blank line at the beginning of a function, so I deleted it.
> test/hotspot/jtreg/runtime/cds/appcds/BadBSM.java line 46:
>
>> 44: TestCommon.list("WrongBSM",
>> 45: "@lambda-proxy WrongBSM 7"),
>> 46: "-Xlog:cds+lambda=debug");
>
> Please align line 46 with 45.
The `"-Xlog:cds+lambda=debug"` parameter is actually at the same level as the `TestCommon.list("WrongBSM",...)` parameter. Aligning it with line 45 would make it look like an argument for the `TestCommon.list()` call.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1062
More information about the hotspot-runtime-dev
mailing list