RFR: 8255973: Add more logging to debug JDK-8255917 [v3]

David Holmes dholmes at openjdk.java.net
Thu Nov 12 07:21:55 UTC 2020


On Thu, 12 Nov 2020 06:10:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make nmt log at debug level, and attempt_reserve_memory_at failed log to os+metaspace debug level
>
> Hi Yumin,
> 
> thinking this through more closely, and looking at your work with JDK-8255917, I am not sure that you really need logging inside NMT. NMT just shows an error we should have detected way earlier when reserving. Knowing when reserve or commit failed would be very helpful.
> 
> Currently I think Iois theory about the split_memory() messing up is the most probable. Even though I am not sure how that could have happened. But could you please also add logging to os::split_memory() on windows? Especially I'd like to know if the two re-reservation calls failed.
> 
> To stop blocking this, I relent and leave all decisions about tags or log level to you. Lets get this logging out of the door, once we found the problem we can brush up the logging in a separate step.

If we are adding _debugging_ output then the log level should be debug IMO.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1150


More information about the hotspot-runtime-dev mailing list