RFR: JDK-8256367: [windows] Better logging for some system calls

Ioi Lam iklam at openjdk.java.net
Mon Nov 16 01:09:55 UTC 2020


On Sat, 14 Nov 2020 06:15:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi,
> 
> may I please have reviews for the following patch. Its purpose is to make error analysis easier for cases like https://bugs.openjdk.java.net/browse/JDK-8255917 or https://bugs.openjdk.java.net/browse/JDK-8255954.
> 
> It does two things:
> - it adds consistent tracing to some of the more important system calls, especially those having to do with virtual memory handling. We now log the success case (on the highest level only) as well as the error case (on the lowest possible level below warning).
> - It adds error handling and logging to os::split_reserved_memory(). It adds an assert if that function fails, since if it fails, we really should stop.
> 
> Thank you,
> 
> Thomas

LGTM. Should the assert in os::split_reserved_memory() be changed to guarantee so it will stop the product build VM?

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1214


More information about the hotspot-runtime-dev mailing list