RFR: JDK-8256367: [windows] Better logging for some system calls
Thomas Stuefe
stuefe at openjdk.java.net
Mon Nov 16 06:19:55 UTC 2020
On Mon, 16 Nov 2020 01:07:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> LGTM. Should the assert in os::split_reserved_memory() be changed to guarantee so it will stop the product build VM?
Thanks Ioi. I'd rather not make it a guarantee - I find those a bad way to communicate errors to the end user. Ideally, the calling function should decide if it is worth continuing, but that would involve fixing ReservedSpace.(first|last)_part and was out of scope for that little fix.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1214
More information about the hotspot-runtime-dev
mailing list