RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v3]

Mandy Chung mchung at openjdk.java.net
Fri Nov 20 03:31:04 UTC 2020


On Thu, 19 Nov 2020 23:03:54 GMT, Mark Reinhold <mr at openjdk.org> wrote:

>> test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java line 387:
>> 
>>> 385:                 "--illegal-access=permit");
>>> 386:     }
>>> 387: 
>> 
>> I see `setAccessibleNonPublicMemberExportedPackage` test case testing with `--add-exports` and `--add-opens` and `Add-Opens` in JAR file manifest but not testing with `Add-Exports`.
>> 
>> Is it worth to include the `Add-Exports` test case?
>> 
>> Other than this, looks good.
>
> Good point -- case added.

Looks good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1324


More information about the hotspot-runtime-dev mailing list