RFR: 8256485: Zero VM build broken after JDK-8254231

Jorn Vernee jvernee at openjdk.java.net
Mon Nov 23 12:49:57 UTC 2020


On Mon, 23 Nov 2020 12:46:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> JDK-8254231 breaks the Zero VM build. This PR contains fixes to get it working again.
>> 
>> Testing: Building zero VM variant on Linux.
>
> src/hotspot/cpu/zero/foreign_globals_zero.hpp line 25:
> 
>> 23: 
>> 24: #ifndef CPU_ZERO_VM_FOREIGN_GLOBALS_X86_HPP
>> 25: #define CPU_ZERO_VM_FOREIGN_GLOBALS_X86_HPP
> 
> Maybe include guards should be `CPU_ZERO_VM_FOREIGN_GLOBALS_ZERO_HPP`, dropping `X86` for `ZERO`.

Ah, good catch. I only changed the first one

-------------

PR: https://git.openjdk.java.net/jdk/pull/1265


More information about the hotspot-runtime-dev mailing list