RFR: 8256489: Make gtest for long path names on Windows more resilient in the presence of virus scanners [v2]

Christoph Langer clanger at openjdk.java.net
Tue Nov 24 23:42:05 UTC 2020


On Tue, 24 Nov 2020 09:32:18 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

>> Hi,
>> 
>> a virus scanner can keep a file open on Windows, so that a DeleteFile command returns successful, but the file is actually not removed when the call returns. In the gtest for long path names on Windows this can lead to failures when a directory is tried to be removed, but the file inside it is still kept by the virus scanner.
>> 
>> Since this is an error which only occurs very infrequently, we just retry the deletion a few times. 
>> 
>> Best regards,
>> Ralf
>
> Ralf Schmelter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Incorporated review findings from David Holmes
>  - Make directory removal in path test more resilient

Marked as reviewed by clanger (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1380


More information about the hotspot-runtime-dev mailing list