RFR: JDK-8257042: [aix] Disable os.release_one_mapping_multi_commits_vm gtest
Aleksey Shipilev
shade at openjdk.java.net
Wed Nov 25 08:25:57 UTC 2020
On Wed, 25 Nov 2020 07:59:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> On AIX, os::release_memory() cannot release multi-mappings since os::reserve_memory() may return system V shared memory instead of the usual mmapped memory. This makes a new gtest fail.
>
> This is very difficult to fix, therefore lets just disable this test for now.
>
> For details about the underlying issue, see https://bugs.openjdk.java.net/browse/JDK-8257041.
>
> --
>
> patch disables the test for AIX, and also needs to disable the local reserve helper function to avoid an "unused symbol" warning.
Looks fine. I guess you don't actually need to `ifndef` the `reserve_multiple`, which is not a test in itself. But omitting that `ifndef` probably sets you up for "unused method" warnings on AIX?
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1426
More information about the hotspot-runtime-dev
mailing list