RFR: 8253926: Use extra_size correctly in anon_mmap_aligned

Aleksey Shipilev shade at openjdk.java.net
Fri Oct 2 10:25:37 UTC 2020


On Fri, 2 Oct 2020 10:00:27 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

> A recent cleanup ([8253638: Cleanup os::reserve_memory and remove MAP_FIXED](https://github.com/openjdk/jdk/pull/357/))
> got a size mixed up in `anon_mmap_aligned()`. Instead of passing down the calculated `extra_size` to `anon_mmap()` it
> uses the original size `bytes`.  This resulted in an early crash when using large pages and with this fix the crash
> goes away.

Looks fine. I read the original changeset, and there seem to be no other instances of this error.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/479


More information about the hotspot-runtime-dev mailing list