RFR: 8252324: Signal related code should be shared among POSIX platforms

David Holmes dholmes at openjdk.java.net
Tue Oct 6 01:57:43 UTC 2020


On Mon, 5 Oct 2020 23:56:25 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/os/posix/signals_posix.hpp line 35:
>> 
>>> 33: // Signal number used to suspend/resume a thread
>>> 34: // do not use any signal number less than SIGSEGV, see 4355769
>>> 35: static int SR_signum = SIGUSR2;
>> 
>> Can you hide this in the .cpp file so that you can avoid including <signal.h> in the header file?
>> 
>> And use forward declarations for outputStream, ucontext_t, and siginfo_t.
>
> Note that these changes are not important enough to rerun testing for this cleanup, so you can make it a new RFE.
> Thank you for doing consolidation!

In reply to Coleen's query - SR_signum is referenced from the os_*.cpp files so needs to be in the header file now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/497


More information about the hotspot-runtime-dev mailing list