RFR: 8253909: Implement detailed map file for CDS [v2]
Ioi Lam
iklam at openjdk.java.net
Tue Oct 6 06:59:41 UTC 2020
On Tue, 6 Oct 2020 06:44:54 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback from Thomas Stuefe
>
> src/hotspot/share/runtime/os.hpp line 693:
>
>> 691: static void print_hex_dump(outputStream* st, address start, address end, int unitsize) {
>> 692: print_hex_dump(st, start, end, unitsize, /*bytes_per_line=*/16, /*logical_start=*/start);
>> 693: }
>
> This is a bit unclear. Could we do it like this instead:
>
> // Print a hex dump from [start .. end). Output lines are prefixed with addresses.
> static void print_hex_dump(outputStream* st, address start, address end, int unitsize)
>
>
> // Print a hex dump from [base+start .. base+end). Output lines are prefixed with offset in relation to base.
> static void print_hex_dump(outputStream* st, address base, intx start, intx end, int unitsize)
But this is not what I want. I am calling with parameters like:
print_hex_dump(st, /*start=*/0x7ffff0000, end, unitsize, bytes_per_line, /*logical_start=*/0x800000000);
So my buffer is at some random address, but I want the print out to pretend that it started at 0x800000000.
-------------
PR: https://git.openjdk.java.net/jdk/pull/474
More information about the hotspot-runtime-dev
mailing list