RFR: 8252324: Signal related code should be shared among POSIX platforms

[David Holmes]

On 6/10/2020 4:06 pm, Thomas Stuefe wrote:
> On Tue, 6 Oct 2020 01:52:21 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> Note that these changes are not important enough to rerun testing for this cleanup, so you can make it a new RFE.
>>> Thank you for doing consolidation!
>>
>> In reply to Coleen's query - SR_signum is referenced from the os_*.cpp files so needs to be in the header file now.
> 
> I wondered why this is not const then I saw that it can be overwritten with an environment variable "_JAVA_SR_SIGNUM".
> Is this still needed? Seems to be an odd way of specifying a VM parameter. And it seems to be untested (I did not find
> any tests for that in the open codebase).

Yes this is still needed to allow apps that use SIGUSR2 themselves to 
set a different signal for suspend/resume. Does anyone use this? I've no 
idea. But not a reason to remove functionality. I'd have to do some 
archaeology to see why its set via an env var.

But you are right that it isn't tested - though the code is pretty 
straight-forward.

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/497
>