RFR: 8252324: Signal related code should be shared among POSIX platforms

Gerard Ziemski gziemski at openjdk.java.net
Tue Oct 6 15:51:09 UTC 2020


On Tue, 6 Oct 2020 06:03:37 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This is a fresh start for https://github.com/openjdk/jdk/pull/157
>> 
>> Please review this change that refactors common POSIX code into a separate
>> file.
>> 
>> Currently there appears to be quite a bit of duplicated code among POSIX
>> platforms, which makes it difficult to apply single fix to the signal code.
>> With this fix, we will only need to touch single file for common POSIX
>> code fixes from now on.
>> 
>> ---------
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>> - [ ] Change must be properly reviewed
>> 
>> 
>> 
>> ### Download
>> `$ git fetch https://git.openjdk.java.net/jdk pull/497/head:pull/497`
>> `$ git checkout pull/497`
>
> Looks good to me. All remarks are just proposals for follow ups. Our nightly tests on AIX went through with the current
> version of the patch. Ship it. Thanks for your work!

Thank you all very much for your feedback and suggestions.

I explicitly did not to put any fixes in this PR, as it was only about refactoring the existing code and I think
everyone understands that.

Any non-trivial suggestions, many of which I wanted to see fixed myself while working on this refactoring, will be
addressed in https://bugs.openjdk.java.net/browse/JDK-8253742

In this, hopefully last commit, I will implement 2 trivial changes:

- David's request to delete comment on 4528190
- Thomas' request to delete empty lines

which hopefully means that Thomas does not need to spin yet another test at SAP.

> src/hotspot/os/posix/signals_posix.cpp line 104:
> 
>> 102: static const struct {
>> 103:   int sig; const char* name;
>> 104: }
> 
> Please remove newlines. This is one declaration:
> 
> static const struct {
>  ,,
> } g_signal_info[] = {

Fixed, will commit shortly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/497


More information about the hotspot-runtime-dev mailing list