RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v3]

Severin Gehwolf sgehwolf at openjdk.java.net
Wed Oct 7 19:34:12 UTC 2020


On Wed, 7 Oct 2020 19:05:57 GMT, Bob Vandette <bobv at openjdk.org> wrote:

>> @bobvandette Done in the latest version. Thoughts?
>
> I'm a little uncomfortable making such a dramatic change just to fix this small isolated problem.   I think about all
> the churn we've had on these files and the backports to come.  Could you just add a
> CgroupSubsystemFactory::isValidSubsystem function which checks for cpuset, cpuacct, memory, etc instead of the major
> change?

Thanks for having a look! Sure, we could do that instead. I'm not sure this is the best solution going forward, though.
Thinking about JDK 17...

Anyway, I'll look into a more conservative fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/485


More information about the hotspot-runtime-dev mailing list