RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v5]

Bob Vandette bobv at openjdk.java.net
Thu Oct 8 14:03:50 UTC 2020


On Thu, 8 Oct 2020 13:36:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java line 185:
>> 
>>> 183:          } else {
>>> 184:            // fallback to old, pre JDK-8245543, behaviour
>>> 185:            return line.contains("cgroup");
>> 
>> Why are you doing this fallback rather than returning false??
>
> The idea was to have have some basics working even though the pattern doesn't match for some reason. I guess we can
> remove that as it's rather unlikely to not match.

The change looks good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/485


More information about the hotspot-runtime-dev mailing list