RFR: 8254262: jdk.test.lib.Utils::createTemp* don't pass attrs

Igor Ignatyev iignatyev at openjdk.java.net
Thu Oct 8 19:12:22 UTC 2020


On Thu, 8 Oct 2020 18:55:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi all,
>> 
>> `jdk.test.lib.Utils::createTempFile` and `createTempDirectory` methods accept `attrs`, but don't pass it to
>> `java.nio.file.Files::createTempFile` and `createTempDirectory` methods respectively. could you please review this
>> trivial patch which fixes that?  Thanks,
>> -- Igor
>
> Looks fine. There seems to be no uses of `Utils.createTempFile` or `Utils.createTempDirectory` with extended
> attributes, so there is no affected tests, and no further testing needed, right?

Thanks for your review, Aleksey.

> There seems to be no uses of `Utils.createTempFile` or `Utils.createTempDirectory` with extended attributes, so there
> is no affected tests, and no further testing needed, right?

correct. I should have stated that in the descriptions, there are no existing tests that specify `attrs`, hence no
affected tests, and no testing needed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/567


More information about the hotspot-runtime-dev mailing list