RFR: 8254599: CDS dump should not warn about hidden classes

Ioi Lam iklam at openjdk.java.net
Mon Oct 12 22:47:12 UTC 2020


On Mon, 12 Oct 2020 18:57:54 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Regular hidden class skipping warning in -Xshare:dump is at info log level, it is noise for a normal operation. Changed
> to debug level, along the change, three test cases in dynamic dumping changed to debug log level to have original
> message output.   Tests: tier1-5 in progress. Passed all local runtime/cds

Changes requested by iklam (Reviewer).

src/hotspot/share/classfile/systemDictionaryShared.cpp line 1349:

> 1347:
> 1348:   if (k->is_hidden() && !is_registered_lambda_proxy_class(k)) {
> 1349:     log_debug(cds)("Skipping %s: %s", k->name()->as_C_string(), "Hidden class");

A ResourceMark is needed here for calling k->name()->as_C_string().

-------------

PR: https://git.openjdk.java.net/jdk/pull/614


More information about the hotspot-runtime-dev mailing list