RFR: 8254158: Consolidate per-platform stack overflow handling code

Harold Seigel hseigel at openjdk.java.net
Tue Oct 13 19:41:12 UTC 2020


On Mon, 12 Oct 2020 22:28:40 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Moved the duplicated code from posix based platform/cpu combinations into os_posix.cpp.  Left a little function to
> determine frame at stack banging point for compiled methods (you can suggest a better name for it) to capture the
> difference.  There are a bit of ifdefs but now there are less copies.
> 
> Tested with tier1-3 and stack overflow tests in vmTestbase/nsk/stress/stack on
> linux-x86-debug,macosx-x86-debug,windows-x86-debug.  Built aarch64, arm32, ppc, s390, and zero.  Testing on these
> platforms would be welcome.  Thanks,
> Coleen

The changes look good.  Thanks for consolidating this code.

-------------

Marked as reviewed by hseigel (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/620


More information about the hotspot-runtime-dev mailing list