RFR: 8254263: Remove special_runtime_exit_condition() check from ~ThreadInVMForHandshake() [v3]

[Robbin Ehn]

On Tue, 13 Oct 2020 21:45:26 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review the following patch that removes the call to handle_special_runtime_exit_condition() in
>> ~ThreadInVMForHandshake(). This check was added by 8223572 to prevent a JavaThread that was suspended while trying to
>> process a handshake to transition back to java without noticing it was suspended. Since 8238761, a JavaThread executing
>> HandshakeState::process_by_self() will never become safe. It comes from an unsafe state and remains unsafe, so it
>> cannot be suspended during that time. Removing this check also removes one of the reasons
>> SafepointMechanism::process_if_requested() is recursive (the other one remains SafepointSynchronize::block()). Tested
>> in mach5, tiers 1-7.  Thanks, Patricio
>
> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix assert message

Thanks Patricio. Good getting rid of the recursive case.

-------------

Marked as reviewed by rehn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/577