RFR: 8253920: Share method trampolines in CDS dynamic archive [v2]

Yumin Qi minqi at openjdk.java.net
Mon Oct 26 20:41:29 UTC 2020


On Mon, 26 Oct 2020 20:34:49 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> src/hotspot/share/oops/method.cpp line 1111:
>> 
>>> 1109: 
>>> 1110:   assert(_from_compiled_entry != NULL, "sanity");
>>> 1111:   if (DumpSharedSpaces) {
>> 
>> I think you can remove this if check.
>
> No, I can't remove the check. It doesn't work with the DynamicDumpSharedSpaces case. Note that the conditions of the assert statements are the same as the original code.

Yes, I mess up with the two. Then it is OK, thanks for the explain.

-------------

PR: https://git.openjdk.java.net/jdk/pull/868


More information about the hotspot-runtime-dev mailing list