RFR: 8253920: Share method trampolines in CDS dynamic archive [v2]

Ioi Lam iklam at openjdk.java.net
Mon Oct 26 22:13:21 UTC 2020


On Mon, 26 Oct 2020 20:37:37 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> No, I can't remove the check. It doesn't work with the DynamicDumpSharedSpaces case. Note that the conditions of the assert statements are the same as the original code.
>
> Yes, I mess up with the two. Then it is OK, thanks for the explain.

I sent Calvin a patch which will allow the `if (DumpSharedSpaces)` to be removed. The rest of the changes look good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/868


More information about the hotspot-runtime-dev mailing list