RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code

Alan Bateman Alan.Bateman at oracle.com
Fri Sep 4 09:10:07 UTC 2020


On 04/09/2020 05:37, Yumin Qi wrote:
> HI, Sundar
>
>   Thanks for review.
>
> On 9/3/20 6:34 PM, sundararajan.athijegannathan at oracle.com wrote:
>> Looks good to me.
>>
>> Few minor comment:
>>
>> * traceFileStream (and even the preexisting mainArgument) is accessed 
>> only inside GenerateJLIClassesPlugin. Could be private?
>>
> I will fix them before push. (Certainly will build first to verify that).
I went through the refactoring of the jlink plugin and I think it looks 
good too.

-Alan.


More information about the hotspot-runtime-dev mailing list