RFR(S) : 8252004 : remove usage of PropertyResolvingWrapper in vmTestbase/nsk/sysdict

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Sep 4 16:43:03 UTC 2020


Thumbs up. Reviewed the patch since that was easy to scroll through.

Dan


On 9/4/20 12:18 PM, Igor Ignatyev wrote:
> can I get an LGTM from someone w/ a Reviewer status before hg repo became read-only?
>
> -- Igor
>
>> On Aug 31, 2020, at 2:50 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>
>> Hi Gerard,
>>
>> thanks for your review.
>>
>> 8219408 is to update tests residing in test/jdk, hotspot tests are going to be updated by 8219140's sub-tasks, which include 8252004 and 8252002. I am not updating all hotspot tests by one patch, b/c in some cases, the tests need small modification to work w/o PropertyResolvingWrapper and splitting the work by test groups make it easier to both work on and review such patches.
>>
>> Cheers,
>> -- Igor
>>
>>> On Aug 31, 2020, at 2:12 PM, gerard ziemski <gerard.ziemski at oracle.com> wrote:
>>>
>>> hi Igor,
>>>
>>> Looks fine as far a I can tell, however, other tests are waiting till JDK-8219408 to re-enable allowSmartActionnArgs - why don't we need to wait for that here as well?
>>>
>>> I noticed that there are other issues filed to address the same issue in other tests, of which there are many (i.e. JDK-8252002) - they will be following the same pattern as this one?
>>>
>>>
>>> cheers
>>>
>>>
>>> On 8/31/20 2:02 PM, Igor Ignatyev wrote:
>>>> ping?
>>>>
>>>> -- Igor
>>>>
>>>>> On Aug 21, 2020, at 10:46 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>>>
>>>>> http://cr.openjdk.java.net/~iignatyev/8252004/webrev.00/
>>>>>> 22 lines changed: 0 ins; 22 del; 0 mod;
>>>>> Hi all,
>>>>>
>>>>> could you please review this small patch which removes usage of PropertyResolvingWrapper from nsk/sysdict tests and reenables allowSmartActionArgs?
>>>>>
>>>>> background from the main bug:
>>>>>> CODETOOLS-7902352 added support of using ${property} in action directive, so PropertyResolvingWrapper isn't needed anymore and can be removed.
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8252004
>>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8252004/webrev.00
>>>>> testing: :vmTestbase_nsk_sysdict
>>>>>
>>>>> Thanks,
>>>>> -- Igor
>>>>>



More information about the hotspot-runtime-dev mailing list