RFR: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
Bob Vandette
bob.vandette at oracle.com
Wed Sep 9 13:36:13 UTC 2020
Yes, this is fine. I looked through the java.base implementation as well and verified that there are no other instances and
that we were not assuming milliseconds in any calculations.
Bob.
> On Sep 9, 2020, at 3:42 AM, Severin Gehwolf <sgehwolf at openjdk.java.net> wrote:
>
> On Wed, 9 Sep 2020 07:34:50 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>
>> The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for
>> microseconds, which is read verbatim. Similarly for cgroups v2
>> all units in 'cpu.max' are in microseconds.
>
> @bobvandette Please have a look it's a pretty trivial change.
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/91
More information about the hotspot-runtime-dev
mailing list