RFR: 8253033: CheckUnhandledOops check fails in ThreadSnapshot::initialize…

Coleen Phillimore coleenp at openjdk.java.net
Fri Sep 11 00:22:44 UTC 2020


On Thu, 10 Sep 2020 23:38:45 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The NULL oops are corrupted by CheckUnhandledOops and should be re-written with NULL to pass testing
> with -XX:+CheckUnhandledOops.

Changes requested by coleenp (Reviewer).

src/hotspot/share/services/threadService.cpp line 888:

> 886:       _thread_status == java_lang_Thread::IN_OBJECT_WAIT_TIMED) {
> 887:
> 888:     Handle obj = ThreadService::get_current_contended_monitor(thread);

There must be a safepoint here then.
I think this would be better and safer if blocker_object and blocker_object_owner are Handles.  Can you change them to
Handles?

-------------

PR: https://git.openjdk.java.net/jdk/pull/123


More information about the hotspot-runtime-dev mailing list