RFR: 8248186: Move CDS C++ vtable code to cppVtables.cpp

Coleen Phillimore coleenp at openjdk.java.net
Fri Sep 11 22:32:04 UTC 2020


On Fri, 11 Sep 2020 22:03:27 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> I moved the code that supports C++ vtables in the CDS archive from metaspaceShared.cpp to a new file, cppVtables.cpp.
> To keep the refactoring straightforward, the code is moved verbatim, except for:
> - Methods are renamed from `MetaspaceShared::xx` to `CppVtables::xx`
> - Access to `_mc_region` is changed to the inline function `mc_region()`

Marked as reviewed by coleenp (Reviewer).

src/hotspot/share/memory/cppVtables.cpp line 33:

> 31: #include "oops/instanceMirrorKlass.hpp"
> 32: #include "oops/instanceRefKlass.hpp"
> 33: #include "oops/methodData.hpp"

Did you check that you needed all of these #include files?

-------------

PR: https://git.openjdk.java.net/jdk/pull/136


More information about the hotspot-runtime-dev mailing list