RFR: 8247281: migrate ObjectMonitor::_object to OopStorage [v4]

Daniel D.Daugherty dcubed at openjdk.java.net
Mon Sep 14 20:24:12 UTC 2020


On Mon, 14 Sep 2020 20:10:50 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   kimbarrett CR - made minor changes to address Kim's code review.
>
> src/hotspot/share/gc/shared/space.inline.hpp line 176:
> 
>> 174:       assert(!space->scanned_block_is_obj(cur_obj) || oop(cur_obj)->mark_raw().is_unlocked() ||
>> 175:              oop(cur_obj)->mark_raw().has_bias_pattern() || oop(cur_obj)->mark_raw().has_monitor(),
>> 176:              "these are the only valid states during a mark sweep");
> 
> Is this change related? Also, when moving the assert into the else block it will become always-true because of
> space->scanned_block_is_obj(cur_obj), or am I missing something?

See this comment from Coleen and the replies:
https://github.com/openjdk/jdk/pull/135#discussion_r487300636

Please let me know if that resolved this comment for you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/135


More information about the hotspot-runtime-dev mailing list