RFR: 8247281: migrate ObjectMonitor::_object to OopStorage [v4]

Roman Kennke rkennke at openjdk.java.net
Mon Sep 14 20:54:14 UTC 2020


On Mon, 14 Sep 2020 20:51:34 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> This code seems like something that doesn't belong here anymore.  This code assumed synchronous scanning of oops in
>> ObjectMonitor and scanning memory regions, and that's no longer the case with OopStorage. I think this assert should be
>> removed.  It exports some implementation detail of now completely unrelated code in order to do a very specific check.
>
> @fisk - please chime in here...

I agree. Also, the assert becomes true somewhat obviously because of its first clause, which is already guaranteed
because of its placement in the surrounding else-branch (unless something really weird happens).

-------------

PR: https://git.openjdk.java.net/jdk/pull/135


More information about the hotspot-runtime-dev mailing list