RFR: 8247281: migrate ObjectMonitor::_object to OopStorage [v4]

Erik Österlund eosterlund at openjdk.java.net
Mon Sep 14 21:05:31 UTC 2020


On Mon, 14 Sep 2020 20:51:58 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> @fisk - please chime in here...
>
> I agree. Also, the assert becomes true somewhat obviously because of its first clause, which is already guaranteed
> because of its placement in the surrounding else-branch (unless something really weird happens).

I am also 100% okay with just removing the random assertion. We have a whole bunch of other block iteration code in GC
code that does not sprinkle random asserts about what patterns of markWords are supposedly good or bad in live/dead
objects. And I also don't get what kind of bug this would catch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/135


More information about the hotspot-runtime-dev mailing list