RFR: 8252921: NMT overwrite memory type for region assert when building dynamic archive

Zhengyu Gu zgu at openjdk.java.net
Tue Sep 15 20:18:59 UTC 2020


On Tue, 15 Sep 2020 19:31:35 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Thanks for the fix. I've done some testing on the patch. It passed tier1 and also passed running the
> appcds/dynamicArchive/methodHandles/MethodHandlesAsCollectorTest.java test 30 times on Windows and linux. One question
> : why the JavaThread::post_run doesn't need to set the following? set_stack_base(NULL);
> set_stack_size(0);

Thanks for reviewing, Calvin.

The last statement of JavaThread::post_run() deletes 'thread' object, so there is no point to reset its states here.
While NonJavaThread object lives pass lifespan of actual thread, its state does matter, I believe.

-------------

PR: https://git.openjdk.java.net/jdk/pull/185


More information about the hotspot-runtime-dev mailing list