RFR: 8253284: Zero OrderAccess barrier mappings are incorrect

David Holmes dholmes at openjdk.java.net
Thu Sep 17 12:22:00 UTC 2020


On Thu, 17 Sep 2020 11:35:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> There are some jcstress failures with AArch64 Zero. It seems because to happen because `orderAccess_linux_zero.hpp`
> defaults to compiler-only barriers for most OrderAccess::* calls. We need to defer to the strongest barriers by
> default.   The code also needs some rearrangement to make the mappings clear.

Looks reasonable other than the ifdef ARM issue.

src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.hpp line 31:

> 29: // Included in orderAccess.hpp header file.
> 30:
> 31: #ifdef ARM

I assume this should have been changed to #if defined(ARM) ??

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/224


More information about the hotspot-runtime-dev mailing list