RFR: 8253314: precompiled.hpp missing from vmIntrinsics.cpp

Ioi Lam iklam at openjdk.java.net
Thu Sep 17 23:08:17 UTC 2020


On Thu, 17 Sep 2020 22:53:02 GMT, John Tortugo <github.com+2249648+JohnTortugo at openjdk.org> wrote:

> @iklam - I had tested the PR that introduced this build break only using a release config (and more recently on a
> fastdebug). What other config did I miss beside `fastdebug`?
> Sorry for all this trouble.

Our continuous integration pipeline tests a variety of builds. Some are configured with --disable-precompiled-headers,
which detected [JDK-8253313](https://bugs.openjdk.java.net/browse/JDK-8253313). We also have Windows builds, which
enable PCH and require that each file has precompiled.hpp.

I was my fault. As a sponsor, I should have tested the changes before integrating the code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/231


More information about the hotspot-runtime-dev mailing list