RFR: 8238761: Asynchronous handshakes [v3]

Robbin Ehn rehn at openjdk.java.net
Mon Sep 21 08:51:26 UTC 2020


On Fri, 18 Sep 2020 20:07:47 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed double check, fix comment, removed not needed function, updated logs
>
> src/hotspot/share/runtime/handshake.hpp line 108:
> 
>> 106:       _processed,
>> 107:       _succeed,
>> 108:       _number_states
> 
> Why are these indented by 4 spaces instead of 2 spaces?

Fixed

> src/hotspot/share/runtime/handshake.cpp line 70:
> 
>> 68:     : HandshakeOperation(cl, target), _start_time_ns(start_ns) {}
>> 69:   virtual ~AsyncHandshakeOperation() { delete _handshake_cl; };
>> 70:   jlong start_time()                 { return _start_time_ns; }
> 
> Should this be 'const'? Ignore it if it would fan out too much.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/151


More information about the hotspot-runtime-dev mailing list