RFR: 8253079: DeterministicDump.java fails due to garbage in structure padding [v3]

[Ioi Lam]

On Mon, 21 Sep 2020 05:45:34 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   also reset trace_id
>
> src/hotspot/share/classfile/moduleEntry.cpp line 457:
> 
>> 455:     _location = ArchiveBuilder::get_relocated_symbol(_location);
>> 456:   }
>> 457:   JFR_ONLY(memset(trace_id_addr(), 0, sizeof(traceid)));
> 
> `memset` looks dodgy here. Maybe `JFR_ONLY(set_trace_id(0))`?

I removed these from my previous commit, because the trace_id seemed to be predictable and wouldn't cause the archive
content to change. Anyway, I've added the code you suggested in commit
[5706a82](https://github.com/openjdk/jdk/pull/267/commits/5706a821a4b96c1c44c44ccf6d78c0659a6f2976). That way, if
trace_ids become unpredictable due to future JFR implementation changes, the CDS code won't be affected.

-------------

PR: https://git.openjdk.java.net/jdk/pull/267