RFR: 8253241: Update comment on java_suspend_self_with_safepoint_check() [v2]

David Holmes dholmes at openjdk.java.net
Tue Sep 22 09:07:45 UTC 2020


On Mon, 21 Sep 2020 10:01:42 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> After JDK-8252414 the safepoint/handshake code does not take _suspend_flags into accout anymore in its assessment if a
>> thread is safepoint/handshake safe. This change updates the comment on
>> JavaThread::java_suspend_self_with_safepoint_check().  I have (not yet) fixed the line breaks (fill-paragraph in emacs
>> lingo) for a clearer diff.
>> Also I could inline the (*) footnote.
>
> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply version proposed by dholmes

LGTM! :) Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/225


More information about the hotspot-runtime-dev mailing list