RFR: 8238761: Asynchronous handshakes [v5]

Robbin Ehn rehn at openjdk.java.net
Wed Sep 23 10:25:56 UTC 2020


On Wed, 23 Sep 2020 04:03:30 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after Coleen
>
> src/hotspot/share/utilities/filterQueue.hpp line 32:
> 
>> 30:
>> 31: template <class E>
>> 32: class FilterQueue {
> 
> A brief description of the class would be good. It is basically a FIFO queue but with the ability to skip nodes that
> match a given "filter" criteria.

Added

> src/hotspot/share/utilities/filterQueue.hpp line 34:
> 
>> 32: class FilterQueue {
>> 33:  private:
>> 34:   class FilterQueueNode : public CHeapObj<mtInternal> {
> 
> The Filter in FilterQueueNode is redundant given this is a nested type. Node would suffice.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/151


More information about the hotspot-runtime-dev mailing list