RFR: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Sep 23 17:29:50 UTC 2020


On Wed, 23 Sep 2020 17:26:16 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> That the monitor has already been unlocked, or is a null stacklock monitor has been already checked in the caller, so
>> the code that makes it a JRT_ENTRY_NO_ASYNC is unnecessary.
>> Making it a JRT_LEAF like the compiled method entries makes it safer. We know it can never safepoint and
>> unintentionally install a async exception.
>> Tested with tier1-6.
>
> Changes requested by dcubed (Reviewer).

The review invite says this:
> That the monitor has already been unlocked, or is a null stacklock monitor has been already checked in the caller
so I also need to go look at the caller contexts.

-------------

PR: https://git.openjdk.java.net/jdk/pull/320


More information about the hotspot-runtime-dev mailing list