RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v2]

Thomas Stuefe stuefe at openjdk.java.net
Fri Sep 25 11:00:21 UTC 2020


On Fri, 25 Sep 2020 07:51:51 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove empty lines from include sections
>
> src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp line 47:
> 
>> 45: #include "runtime/mutexLocker.hpp"
>> 46: #include "runtime/os.hpp"
>> 47:
> 
> Just a drive-by comment. Please don't introduce this new style of adding newlines between our internal include lines.
> The same comment about the newlines after precompiled.hpp. I know that the Shenandoah code already does that, and I've
> seen some of the metaspace code do that as well, but please stick to the set standard way of listing our includes. This
> applies to all files in this patch.

Sure, no problem. I changed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336


More information about the hotspot-runtime-dev mailing list