RFR: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 … [v2]

[Severin Gehwolf]

On Fri, 25 Sep 2020 15:13:29 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this change to fix memory docker tests failures on some Linux kernels w/o cgroupv1 swap limit
>> capabilities.  The fix works by detecting that swap limit capabilities are not available and returning non-swap related
>> information.  For example, if memory and swap usage is requested, and swap limit capabilities are not available, then
>> only memory usage is returned.  The fix was tested by running container tests on systems with and without swap limit
>> capabilities.  Additionally, the changes were regression tested by running tier1 and tier2 tests on Windows, Linux x64,
>> and Mac OS, and running tier3 - tier5 tests on Linux x64.
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities

I'll also run this through testing and will report back.

test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java line 167:

> 165:             out.shouldContain("OperatingSystemMXBean.getTotalSwapSpaceSize: " + expectedSwap);
> 166:         } catch(RuntimeException ex) {
> 167:             out.shouldMatch("OperatingSystemMXBean.getTotalSwapSpaceSize: [0-9]+");

This should probably be:
out.shouldMatch("OperatingSystemMXBean\.getTotalSwapSpaceSize: [0-9]+");

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/342